Updating older mysql_ code

Description

What is interesting is there are still a number of programs in 2.5.4 that still use mysql_num_rows instead of tep_db_num_rows and I have to wonder if that is worthy of attention? The list of files that still use mysql_num_rows is:

catalog/admin/recover_cart_sales.php
catalog/templates/fallback/content/catalog_products_with_images.tpl.php
catalog/sitemap.class.php
catalog/admin/new_attributes_include.php
catalog/admin/stats_recover_cart_sales.php
catalog/admin/new_attributes_functions.php
catalog/admin/new_attributes_change.php
catalog/admin/new_attributes.php

In the following two files:

catalog/includes/functions/database.php
catalog/admin/includes/functions/database.php

they each have the line:

function tep_db_num_rows($db_query) {
return mysql_num_rows($db_query);
}

Which I assume are to fix all occurrences of tep_db_num_rows to behave as mysql_num_rows - however isn't the problem mysql_* being dropped as of PHP 7.0 and has been deprecated since 5.5.0?

I see where one may be able to substitute mysql_ with mysqli_ ($link, etc.) and achieve the same results, is this being considered? There are roughly 60 files in 2.5.4 that use mysql_xxx.

Complete list:

Environment

None

Steps to reproduce

None

Status

Assignee

Michael Sasek

Reporter

John Robertson

Labels

None

Severity

None

Fix versions

Affects versions

2.5.4

Priority

High
Configure